Rework of player's Firing function

 Author: Daniel Jackson


The players fire function was exceeding 1,000 lines and causing a drop in frames anytime the player was firing any weapon. Each time any weapon was fired the weapon checked its current type against every weapon type and its current magazine to see if it could be fired. These repeated checks were causing frames drops and made the function more difficult to read.

To fix this I shifted our player's current weapon to be a pointer to a particular weapon in its arsenal so we could skip going through the entire arsenal every fire. Then I shifted our fire into a switch case using its weapon type and was able to remove most of the code checking each weapon's magazine and instead only check our current weapon and then go through the appropriate checks. This drastically shortened the fire function and decreased the average amount of checks per fire, and I plan to shorten it even further using this new system.


(Lines from fire commented out just prior to deletion)

(Entire block could not fit on screen even when zoomed out)



(New fire function)




Comments

Post a Comment

Popular posts from this blog

Adding assets to every enemy -- Owen Meyers

Image
      As with every game, it is very important to have assets to denote which enemy is which. Being able to tell at a glance what enemy you are encountering before receiving a face full of buckshot is incredibly important. The issue for Project [REDACTED] is that we didn't have any artists working full time to deliver assets for the enemies. Thus, it fell upon me, the designer of the asset pipeline, to acquire assets for every enemy. This led to having to fix models and integrate animations, with each problem being subtly different.     Take, for example, the shotgunner model. His original model was designed for an OpenGL renderer, and was flipped 180 degrees for that very reason. In addition to this, he was also placed halfway in the ground, likely due to something required for that game's collision to function. Fixing this model to function for our renderer required that it be re-rigged and most of the animations acquired from Mixamo. With the help of Kris, and several hours
Read more

Sphere to AABB collision

       I had a problem today when trying to detect sphere to AABB collision. For some reason the collision check that I made was never turning true even though I could clearly see the sphere hitting the AABB. This was a big problem as we needed this collision to detect whether any entities are hitting walls.     I discovered that the problem with this bug was that I was improperly getting the closest point in the AABB to the sphere. The way I fixed this problem this problem was by getting the max vertex that the circle center could be and using that to get the closest point on the AABB to then determine the minimum vertex between the sphere's max vertex and the max of the AABB.  Once I found this point, I could properly compare the distance of that point to the center of the sphere. This solution will allow detection between walls and any sphere collider such as the player collider, and enemy collider. This is very important to make sure they both stay within the level bounds.
Read more